Skip to content

Conversation

@chelovechishko
Copy link
Contributor

Also slight rearrangement of properties to more alphabetical.

Also slight rearrangement of properties to more alphabetical.
@yaronf
Copy link
Owner

yaronf commented Jan 20, 2024

This simply doesn't work for me, Firefox 121. I change the browser's color scheme between Dark and Light and the Preferences dialog doesn't change.

@chelovechishko
Copy link
Contributor Author

Hm-m-m, strange. I have set it to "automatic", and only checked, that options.html will be dark for me.
console.log(window.matchMedia("(prefers-color-scheme: dark)").matches); for me returns true always for add-on, e. g. if i choose light instead of auto theme it won't change.


And this worked in about:addons -> settings for overlay-clock.
Looks like just one more firefox gui bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1587723

@yaronf
Copy link
Owner

yaronf commented Jan 21, 2024

So yes, it works fine from about:addons -> settings for overlay-clock.

But not when pressing the clock icon to open the Preferences dialog. That one is stuck in light mode, even when I restart FF.

@chelovechishko
Copy link
Contributor Author

And for me, it's always in dark mode.
In about:config have widget.content.allow-gtk-dark-theme = true and layout.css.light-dark.enabled = true, btw, who knows, what exactly setting is needed for add-on to be in dark mode by default.
As it doesn't change colors for your usual theme, and for mine (it's dark one), it should not matter so much for users. i hope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants