Skip to content

Conversation

@yaronf
Copy link
Owner

@yaronf yaronf commented Jan 21, 2024

Move to Manifest v3, as mandated by the Chrome browser.

@yaronf
Copy link
Owner Author

yaronf commented Jan 21, 2024

@chelovechishko I see several options and I need your help to decide:

  1. Merge and deploy as is. This works fine on Chrome, but on FF users need to enable the extension separately on each tab. I think this is way too much friction. See this post: https://blog.mozilla.org/addons/2022/11/17/unified-extensions-button-and-how-to-handle-permissions-in-manifest-v3/
  2. Add UI to ask FF users to enable permissions for all tabs (or maybe for specific tabs/domains). I think this is possible but I'd need your help there.
  3. Split the code so that FF remains on V2 and Chrome moves to V3. This is OK for now but could be painful long term.

WDYT?

@yaronf yaronf changed the title Manifestv3 Manifest V3 Jan 21, 2024
@chelovechishko
Copy link
Contributor

As Firefox is great browser ©®™, it fine with manifest v2, they not (at least yet) abandon v2.
As you already updated firefox version, (for some years, heh) users (2½) could wait (also, i didn't think, that you will update version with barely one (fat lie) commit, without others (like all, except migrating or so to v3), but whatever.
To not, just updating several manifest things is too little, as for me. But when chrome will refuse to accept v2? I aware, that they postponed translation date some time ago (maybe years?), but don't know the doomsdate. As manifest v3 mostly for more asynchronous here and there (but chrome still don't have promises everywhere in what we use here), it should have async and await almost everywhere (while code will not break, i guess).

Of course, we can use different manifest file for chrome for now.
Btw, how did you know, that firefox needs that? With just temporary add-on, i didn't have any askings for permission (but i have customized version, without require signing and such). Does it behaves differently when add-on not temporary? As asking permissions for every extension for almost every page would be really shit decision, so i wonder. We have only matches, not any host_permissions. Like i have checkbox in unified button for exactly one extension for "enable for this domain", but never used that, and maybe still on manifest v2 only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants