build: switch to peer dependencies#12
Draft
bchrobot wants to merge 3 commits intoyasserf:mainfrom
Draft
Conversation
Owner
|
hey! Thanks for raising. I like the idea, feel like we might want to then publish three packages (one for pg, one for mysql, and then with this change). That way it would still just work via global installs. Thoughts? |
Owner
|
@bchrobot revisited this, but I still think for the average install it would be annoying to have to install the specific driver. But I also see the value in this.. happy to merge in if the idea is voted on/brought on by anyone else |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
schematsshould be usable against one database type without needing to install the other database as well.These changes have not been widely tested but I wanted to at least open the door to what peer dependencies could look like.