Conversation
WalkthroughThis pull request updates multiple Rust dependencies in Cargo.toml: arrow and arrow-schema to version 56.0.0, sqlparser to 0.58.0, and datafusion to 50.2.0. Additionally, the datafusion_pg_catalog dependency branch is switched from "register_to_inf_schema" to "main". Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related issues
Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
Cargo.toml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: unit-tests
- GitHub Check: unit-tests
| arrow = { version = "56.0.0", features = ["ffi", "canonical_extension_types"] } | ||
| sqlparser = "0.58.0" | ||
|
|
||
|
|
||
| chrono = "0.4.41" | ||
| log = "0.4" | ||
| datafusion = "47.0.0" | ||
| datafusion_pg_catalog = { git = "https://github.com/ybrs/pg_catalog", branch = "register_to_inf_schema", package = "datafusion_pg_catalog" } | ||
| datafusion = "50.2.0" | ||
| datafusion_pg_catalog = { git = "https://github.com/ybrs/pg_catalog", branch = "main", package = "datafusion_pg_catalog" } |
There was a problem hiding this comment.
Hold: sqlparser 0.58.0 is ahead of DataFusion 50.2.0
DataFusion 50.2.0 still depends on sqlparser 0.57.x; upgrading sqlparser to 0.58.0 in this crate makes our tree pull two conflicting versions (0.57 from DataFusion and 0.58 here). Cargo will resolve the newer one for our direct uses, but DataFusion continues to compile against 0.57 APIs. Sqlparser 0.58 shipped breaking changes (e.g. AST restructuring around COPY/SHOW statements). That mismatch will surface as compile errors once you rebuild because DataFusion 50’s code no longer matches the newer AST definitions. Please keep sqlparser pinned to 0.57.* (or the version DataFusion 50 uses) until we move DataFusion forward to a release that embeds 0.58.0.
🤖 Prompt for AI Agents
In Cargo.toml around lines 31 to 38, sqlparser was bumped to 0.58.0 which
conflicts with DataFusion 50.2.0 that still depends on sqlparser 0.57.x; change
the sqlparser entry back to the 0.57 series (e.g., sqlparser = "0.57.0" or
"0.57") to match DataFusion’s dependency and avoid AST/API mismatches, and keep
it pinned to that version until DataFusion is upgraded to a release that embeds
sqlparser 0.58.
Summary by CodeRabbit