Skip to content

Upgrade datafusion#108

Merged
ybrs merged 1 commit intomainfrom
upgrade-datafusion-50.2.0
Oct 16, 2025
Merged

Upgrade datafusion#108
ybrs merged 1 commit intomainfrom
upgrade-datafusion-50.2.0

Conversation

@ybrs
Copy link
Copy Markdown
Owner

@ybrs ybrs commented Oct 16, 2025

Summary by CodeRabbit

  • Chores
    • Updated core dependencies to latest stable versions to maintain compatibility and performance.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Oct 16, 2025

Walkthrough

This pull request updates multiple Rust dependencies in Cargo.toml: arrow and arrow-schema to version 56.0.0, sqlparser to 0.58.0, and datafusion to 50.2.0. Additionally, the datafusion_pg_catalog dependency branch is switched from "register_to_inf_schema" to "main".

Changes

Cohort / File(s) Summary
Dependency Version Updates
Cargo.toml
Updated arrow (55.1.0 → 56.0.0), sqlparser (0.55.0 → 0.58.0), datafusion (47.0.0 → 50.2.0), and arrow-schema (55.1.0 → 56.0.0). Switched datafusion_pg_catalog git branch from "register_to_inf_schema" to "main".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related issues

Possibly related PRs

  • Wip datagrip #84: Modifies the datafusion_pg_catalog dependency branch specification, suggesting parallel work on aligning this shared dependency across repositories.
  • wip datagrip #85: Also updates datafusion_pg_catalog dependency configuration, indicating concurrent efforts to manage this transitive dependency.

Poem

🐰 Hops through versions with glee,
Arrow flies to fifty-six so free,
DataFusion leaps ahead to fifty,
Dependencies dance—no need to be thrifty!
From branches old to "main" they run,
Update cascade—version fun!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The PR title "Upgrade datafusion" directly relates to the primary change in the changeset, which upgrades the datafusion dependency from 47.0.0 to 50.2.0. This is confirmed by the source branch name "upgrade-datafusion-50.2.0", indicating datafusion is the main focus. While the PR also upgrades other dependencies (arrow, sqlparser, arrow-schema) and switches a branch for datafusion_pg_catalog, these appear to be supporting or related updates rather than the primary objective. The title is concise, clear, and specific enough that a teammate scanning the history would immediately understand the core purpose of this pull request.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch upgrade-datafusion-50.2.0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6b0db38 and 9a0bac2.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • Cargo.toml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: unit-tests
  • GitHub Check: unit-tests

Comment thread Cargo.toml
Comment on lines +31 to +38
arrow = { version = "56.0.0", features = ["ffi", "canonical_extension_types"] }
sqlparser = "0.58.0"


chrono = "0.4.41"
log = "0.4"
datafusion = "47.0.0"
datafusion_pg_catalog = { git = "https://github.com/ybrs/pg_catalog", branch = "register_to_inf_schema", package = "datafusion_pg_catalog" }
datafusion = "50.2.0"
datafusion_pg_catalog = { git = "https://github.com/ybrs/pg_catalog", branch = "main", package = "datafusion_pg_catalog" }
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Hold: sqlparser 0.58.0 is ahead of DataFusion 50.2.0

DataFusion 50.2.0 still depends on sqlparser 0.57.x; upgrading sqlparser to 0.58.0 in this crate makes our tree pull two conflicting versions (0.57 from DataFusion and 0.58 here). Cargo will resolve the newer one for our direct uses, but DataFusion continues to compile against 0.57 APIs. Sqlparser 0.58 shipped breaking changes (e.g. AST restructuring around COPY/SHOW statements). That mismatch will surface as compile errors once you rebuild because DataFusion 50’s code no longer matches the newer AST definitions. Please keep sqlparser pinned to 0.57.* (or the version DataFusion 50 uses) until we move DataFusion forward to a release that embeds 0.58.0.

🤖 Prompt for AI Agents
In Cargo.toml around lines 31 to 38, sqlparser was bumped to 0.58.0 which
conflicts with DataFusion 50.2.0 that still depends on sqlparser 0.57.x; change
the sqlparser entry back to the 0.57 series (e.g., sqlparser = "0.57.0" or
"0.57") to match DataFusion’s dependency and avoid AST/API mismatches, and keep
it pinned to that version until DataFusion is upgraded to a release that embeds
sqlparser 0.58.

@ybrs ybrs merged commit 4ade7fe into main Oct 16, 2025
3 checks passed
@ybrs ybrs deleted the upgrade-datafusion-50.2.0 branch October 16, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant