Open
Conversation
kksys
commented
Oct 2, 2025
ycanardeau
reviewed
Oct 14, 2025
| @@ -0,0 +1,6 @@ | |||
| :root { | |||
Owner
There was a problem hiding this comment.
Why do you need this css file? I'd like to stick with the default UI style as much as possible without using custom styles.
Comment on lines
+192
to
+195
| style={{ | ||
| paddingLeft: `calc(env(safe-area-inset-left) + ${euiTheme.size.l}px)`, | ||
| paddingRight: `calc(env(safe-area-inset-right) + ${euiTheme.size.l}px)`, | ||
| }} |
Owner
There was a problem hiding this comment.
What's the purpose of this style?
Comment on lines
+201
to
+205
| style={{ | ||
| paddingLeft: `calc(env(safe-area-inset-left) + ${euiTheme.size.l}px)`, | ||
| paddingRight: `calc(env(safe-area-inset-right) + ${euiTheme.size.l}px)`, | ||
| }} | ||
| > |
Comment on lines
+574
to
+578
| style={{ | ||
| paddingLeft: `calc(env(safe-area-inset-left) + ${euiTheme.size.s}px)`, | ||
| paddingRight: `calc(env(safe-area-inset-right) + ${euiTheme.size.s}px)`, | ||
| paddingBottom: `calc(env(safe-area-inset-bottom) + ${euiTheme.size.s}px)`, | ||
| }} |
Comment on lines
+95
to
+100
| style={{ | ||
| paddingTop: 'env(safe-area-inset-top)', | ||
| paddingLeft: `calc(env(safe-area-inset-left) + ${euiTheme.size.s}px)`, | ||
| paddingRight: `calc(env(safe-area-inset-right) + ${euiTheme.size.s}px)`, | ||
| height: 'var(--euiFixedHeadersOffset)', | ||
| }} |
kksys
force-pushed
the
feature/support-safe-area
branch
from
94b5db7 to
aec07f5
Compare
ycanardeau
added a commit
that referenced
this pull request
Dec 30, 2025
…tor-13.15.20 Bump validator from 13.9.0 to 13.15.20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Safe Area Support for Mobile Devices
Overview
This PR adds support for safe area insets, improving the UI experience on devices with notches or rounded corners (such as iPhones and some Android devices). The changes ensure that key UI components are not obscured by device-specific display features.
Relevant Issue
This PR fixes #16
Changes
index.html
viewport-fit=coverto the viewport meta tag.Global Styles
src/styles.cssto define CSS variables for fixed header height and safe area offset.Header, BottomBar, and PlayQueue Components
Header,BottomBar, andHydrangeanDivacomponents to respect safe area insets usingenv(safe-area-inset-*).euiTheme.size.sandeuiTheme.size.l) for consistency.Motivation
Without these adjustments, UI elements may be partially hidden or difficult to interact with on devices with display cutouts. This update ensures a consistent and accessible user experience across all supported devices.
Points for Review
euiThemeUtilization: Assess if using thepaddingvalues fromeuiThemefor layout adjustments in each component seems consistent with our theme and design system.Testing
Verified on below devices:
Confirmed that all interactive elements remain fully visible and accessible.
Before and After Screenshots (or Video)
Portrait
Landscape