index column validation has been added #29626
Conversation
|
⚪ ⚪ Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
🟢 |
There was a problem hiding this comment.
Pull request overview
This PR adds validation to ensure the index column in sparse array chunks is monotonically non-decreasing. The validation prevents data corruption by catching invalid index orderings during sparse array construction.
- Adds an
AFL_VERIFYcheck to validate that index column values don't decrease - Includes diagnostic information (next expected index, current loop index, and actual value) for debugging
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| if (idx - startIndexInt) { | ||
| RemapExternalToInternal.emplace_back(startIndexExt, startIndexInt, idx - startIndexInt, false); | ||
| } | ||
| AFL_VERIFY(UI32ColIndex->Value(idx) >= nextIndex)("next", nextIndex)("idx", idx)("val", UI32ColIndex->Value(idx)); |
There was a problem hiding this comment.
тут три раза вызывается UI32ColIndex->Value(idx). нельзя ли в переменную положить?
There was a problem hiding this comment.
на равенство уже проверили выше в if
2 participants
Changelog entry
...
Changelog category
Description for reviewers
...