Fixed error caused by change to the parent class of Icarus_g2005.#9
Open
dicethrow wants to merge 1 commit intoydnatag:masterfrom
Open
Fixed error caused by change to the parent class of Icarus_g2005.#9dicethrow wants to merge 1 commit intoydnatag:masterfrom
dicethrow wants to merge 1 commit intoydnatag:masterfrom
Conversation
The error I got was that self.compile_args is now a dictionary, rather than an array. Although self.compile_args_flattened seemed to work, I wasn't sure if there were other changes in the parent class that I didn't find. So this commit was implemented to reduce the reliance on the internal structure of the parent class.
Contributor
|
Hi, Still, it's true that with the current implementation any change in the parent class can break this so 👍 to this PR. What do you think @andresdemski ? |
Author
|
Ah my apologies, I referred to the wrong thing in the comment above. It was |
Contributor
|
You're right, I didn't see that! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error I got was that self.compile_args is now a dictionary,
rather than an array. Although self.compile_args_flattened seemed
to work, I wasn't sure if there were other changes in the parent
class that I didn't find.
So this commit was implemented to reduce the reliance on the internal
structure of the parent class.