Skip to content

Fixed error caused by change to the parent class of Icarus_g2005.#9

Open
dicethrow wants to merge 1 commit intoydnatag:masterfrom
dicethrow:master
Open

Fixed error caused by change to the parent class of Icarus_g2005.#9
dicethrow wants to merge 1 commit intoydnatag:masterfrom
dicethrow:master

Conversation

@dicethrow
Copy link

The error I got was that self.compile_args is now a dictionary,
rather than an array. Although self.compile_args_flattened seemed
to work, I wasn't sure if there were other changes in the parent
class that I didn't find.

So this commit was implemented to reduce the reliance on the internal
structure of the parent class.

The error I got was that self.compile_args is now a dictionary,
rather than an array. Although self.compile_args_flattened seemed
to work, I wasn't sure if there were other changes in the parent
class that I didn't find.

So this commit was implemented to reduce the reliance on the internal
structure of the parent class.
@akukulanski
Copy link
Contributor

Hi,
Here I see that self.compile_args is still a list. Where should I look for that change?

Still, it's true that with the current implementation any change in the parent class can break this so 👍 to this PR.

What do you think @andresdemski ?

@dicethrow
Copy link
Author

Ah my apologies, I referred to the wrong thing in the comment above. It was self.verilog_sources that is now a dictionary, and a list form of it is now self.verilog_sources_flat, these are both in the link you shared.

@akukulanski
Copy link
Contributor

You're right, I didn't see that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants