Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
murderteeth
approved these changes
Dec 18, 2025
Contributor
murderteeth
left a comment
murderteeth
left a comment
There was a problem hiding this comment.
approved with comment
|
|
||
| const CACHE_KEY = 'katana-aprs-cache'; | ||
| const CACHE_TTL = 60 * 60 * 1000; // 1 hour | ||
| const CACHE_TTL = 1 * 60 * 1000; // 1 hour |
Contributor
There was a problem hiding this comment.
the latest cache update sets the apr service's cache to 15 min which is reasonable. lets set this to 15 minutes too. per https://github.com/yearn/katana-apr-service/blob/e097e26f812b03a7ce5b75157211fa76fd6e9deb/src/app/api/vaults/route.ts#L20
murderteeth
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested Changes from katana:
2 changes to the APY breakdown notes worth updating before tomorrow to avoid user confusion:
I updated the modal to reflect these changes.