Fixing issue turning pinMode to ANALOG#6
Open
jguille2 wants to merge 1 commit intoyellow-digital:mainfrom
Open
Fixing issue turning pinMode to ANALOG#6jguille2 wants to merge 1 commit intoyellow-digital:mainfrom
jguille2 wants to merge 1 commit intoyellow-digital:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Jelle Hak,
Thanks for your work.
I'm moving Snap4Arduino to a custom Snap! extension, snap_s4aConn, using the WebSerial api... and I'm using your code to get this firmata-web solution.
I was thinking (not only now) that Firmata.js repo was the place to implement this support, but you know all "firmata projects" are pretty much frozen :(
Then, for me, your repo is right now the reference on "Firmata over WebSerial".
I see that a first use of "pinMode" to ANALOG is running ok, because analog reading don't need any activation... but if I turn to other modes and return to ANALOG, reporting is frozen because that change (pinMode to ANALOG) is not reported to the board.
I've also submitted this to firmata/firmata.js repo) but, you know there are other changes on your firmata.js... and, as I said, your repo could be the updated reference for firmata over serial projects.
Thanks
Joan