Fix: Preserve multiple consecutive newlines in TipTap editor#4
Open
AJ-505 wants to merge 1 commit intoyemisi567:masterfrom
Open
Fix: Preserve multiple consecutive newlines in TipTap editor#4AJ-505 wants to merge 1 commit intoyemisi567:masterfrom
AJ-505 wants to merge 1 commit intoyemisi567:masterfrom
Conversation
👷 Deploy request for writeflow-app pending review.Visit the deploys page to approve it
|
|
@AJ-505 is attempting to deploy a commit to the alegbeyemigmailcom's projects Team on Vercel. A member of the Team first needs to authorize it. |
❌ Deploy Preview for yemisienyata failed. Why did it fail? →
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Multiple Newlines Collapsing to Single Line
Issue
When users pressed Enter multiple times to create blank lines, only one blank line would remain after typing resumed. Multiple consecutive newlines were being collapsed into a single newline.
Root Cause
The
TipTapWrapper.tsxHTML-to-blocks conversion was filtering out empty<p>elements:This caused all empty paragraph nodes to be removed during the conversion process, collapsing multiple newlines.
Solution
inline-blockzero-width space and explicit sizingChanges Made
src/components/Editor/TipTapWrapper.tsx: Remove empty content filter for paragraphssrc/index.css: Enhanced empty paragraph CSS rules