Conversation
Changed the defaults for the pageUrl and referrerUrl so they no longer use the Referrer header as a default. Also increased SDK version to 1.0.3
ejaffee01
reviewed
Apr 10, 2025
Contributor
ejaffee01
left a comment
ejaffee01
left a comment
There was a problem hiding this comment.
Changes LGTM but 2 things
Do you think this should be a minor version upgrade or patch version? This feels like new functionality over a bug fix, but might be worth confirming with the team.
Any easy way to update/add a test for this change? If not simple no worries
Contributor
Author
Good catch, it should be a minor version as we are changing the defaults for |
ejaffee01
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the defaults for the pageUrl and referrerUrl so they no longer use the Referrer header as a default.
Also increased SDK version to 1.0.3
https://yexttest.atlassian.net/browse/FUS-7183