Skip to content

Conversation

@mkilpatrick
Copy link
Collaborator

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Dec 23, 2025

⚠️ No Changeset found

Latest commit: 4d36e18

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link

coderabbitai bot commented Dec 23, 2025

Walkthrough

The packages/pages-components/package.json exports field was restructured to flatten the nested "import" object. Previously, the export configuration used exports["."].import as an object containing types and default properties. The new structure elevates these to top-level properties under exports["."], explicitly declaring types, import, and default as separate keys. Other exports and package.json properties remain unchanged.

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess whether any description relates to the changeset. Add a description explaining why the exports structure was changed and what issue this fix addresses.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix: exports resolution' directly relates to the main change, which restructures the exports field in package.json to fix export resolution behavior.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch exports

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1e812b5 and 4d36e18.

📒 Files selected for processing (1)
  • packages/pages-components/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: call_test_matrix / Node 20 • React 18.2.0
  • GitHub Check: call_test_matrix / Node 22 • React 18.2.0
  • GitHub Check: call_test_matrix / Node 24 • React 18.2.0
  • GitHub Check: call_test_matrix / Node 18 • React 18.2.0
  • GitHub Check: semgrep/ci
🔇 Additional comments (1)
packages/pages-components/package.json (1)

26-28: Exports structure correctly flattened.

The restructuring to flat sibling properties (types, import, default) is the correct Node.js package.json exports format. The order—with types first for TypeScript resolution, followed by import for ESM, and default as the universal fallback—aligns with Node.js specification and TypeScript tooling requirements. Both import and default pointing to the same ESM file is appropriate for this ES module-only package.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mkilpatrick mkilpatrick merged commit 80f7728 into main Dec 23, 2025
21 checks passed
@mkilpatrick mkilpatrick deleted the exports branch December 23, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants