Skip to content

Conversation

@mkilpatrick
Copy link
Collaborator

Node 18 was EOL March 27, 2025
Screenshot 2025-12-23 at 2 35 53 PM

@changeset-bot
Copy link

changeset-bot bot commented Dec 23, 2025

⚠️ No Changeset found

Latest commit: d08c6f1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link

coderabbitai bot commented Dec 23, 2025

Walkthrough

This PR removes Node.js 18 support and adds Node.js 24 support across the project. The Node.js version matrix is updated in five GitHub Actions workflows (build, snapshots, test-matrix, unit_test, wcag_test). The package.json engines field is updated in two package manifests to reflect the new minimum version requirement of Node 20. The local test matrix script is also updated to remove Node 18 from the test combinations.

Suggested reviewers

  • briantstephan
  • benlife5
  • asanehisa

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The PR title 'feat!: drop Node 18 support' clearly and concisely summarizes the main change across all modified files.
Description check ✅ Passed The PR description directly relates to the changeset by explaining the rationale (Node 18 EOL) for dropping Node 18 support.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch drop-node18

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 80f7728 and d08c6f1.

📒 Files selected for processing (8)
  • .github/workflows/build.yml
  • .github/workflows/snapshots.yml
  • .github/workflows/test-matrix.yml
  • .github/workflows/unit_test.yml
  • .github/workflows/wcag_test.yml
  • packages/pages-components/package.json
  • test-sites/pages-components-starter/package.json
  • test-sites/pages-components-starter/scripts/test-matrix-local.sh
🔇 Additional comments (8)
.github/workflows/snapshots.yml (1)

16-17: LGTM! Correctly removed Node 18.x from snapshots workflow.

The update removes Node 18.x while maintaining only 20.x, consistent with the existing TODO comment about Node 22.x causing infinite screenshot loops. This is the appropriate change given the known issue.

.github/workflows/unit_test.yml (1)

19-19: LGTM! Unit test matrix updated correctly.

The Node version matrix now properly excludes 18.x and includes 24.x, ensuring unit tests run on all supported Node versions.

.github/workflows/build.yml (1)

19-19: LGTM! Build matrix updated correctly.

The Node version matrix properly reflects the removal of 18.x support and addition of 24.x, ensuring builds are tested across all supported versions.

test-sites/pages-components-starter/scripts/test-matrix-local.sh (1)

12-12: LGTM! Local test matrix updated correctly.

The NODE_VERSIONS array now matches the CI workflow matrices by removing Node 18 and including Node 24, ensuring local testing is consistent with CI.

test-sites/pages-components-starter/package.json (1)

16-16: LGTM! Engine constraint updated correctly.

The Node engine constraint now properly excludes Node 18, with the minimum supported version being 20.2.0. The constraint syntax is valid and consistent with the PR objectives.

.github/workflows/test-matrix.yml (1)

13-13: LGTM! Matrix test workflow updated correctly.

The Node version matrix properly removes Node 18 while maintaining 20, 22, and 24. The format (integers without .x suffix) is consistent with this workflow's existing convention.

.github/workflows/wcag_test.yml (1)

10-10: Node version matrix updated correctly.

Node.js 24 (Active LTS, promoted Oct 28, 2025) is officially released and stable. The removal of Node 18.x and addition of 24.x aligns with supporting current LTS versions. Matrix is properly formatted and consistent with other workflow updates.

packages/pages-components/package.json (1)

34-34: LGTM! Node engine constraint updated correctly.

The Node engine constraint in packages/pages-components/package.json now properly excludes Node 18 support, with a minimum of Node 20. Verification confirms no Node 18 references remain elsewhere in the codebase, and this is the primary breaking change for the package.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mkilpatrick mkilpatrick merged commit 69a1ec0 into main Dec 23, 2025
19 checks passed
@mkilpatrick mkilpatrick deleted the drop-node18 branch December 23, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants