Skip to content

Conversation

@mkilpatrick
Copy link
Collaborator

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Dec 23, 2025

⚠️ No Changeset found

Latest commit: 050e73d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link

coderabbitai bot commented Dec 23, 2025

Walkthrough

This pull request adds support for React 19.2.3 alongside the existing React 18.2.0. The changes update peer dependencies in the main package to accept both React versions, expand test matrices in CI workflows and local test scripts to run against both versions, and mark JSX runtime modules as external in the Vite build configuration. Additionally, the test site starter project is updated to use React 18.2.0 (upgraded from 17.0.2), and test result artifacts are added to gitignore.

Possibly related PRs

Suggested reviewers

  • asanehisa
  • benlife5

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess whether it relates to the changeset. Add a description explaining the changes made to support React 19, such as updating dependencies, extending test matrices, and modifying build configurations.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat: support React 19' accurately captures the main objective of the pull request, which is to add React 19 compatibility across the codebase.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch react19

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 69a1ec0 and 050e73d.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (6)
  • .github/workflows/test-matrix.yml
  • packages/pages-components/package.json
  • packages/pages-components/vite.config.ts
  • test-sites/pages-components-starter/.gitignore
  • test-sites/pages-components-starter/package.json
  • test-sites/pages-components-starter/scripts/test-matrix-local.sh
🔇 Additional comments (6)
test-sites/pages-components-starter/.gitignore (1)

6-7: LGTM!

The addition of test-results/ to gitignore is appropriate for excluding Playwright test artifacts generated by the expanded test matrix.

packages/pages-components/vite.config.ts (1)

17-23: LGTM!

Correctly marks React's JSX runtime modules as external dependencies. This ensures the library doesn't bundle these runtime modules, which is essential for supporting both React 18 and 19 where consumers provide their own React installation.

packages/pages-components/package.json (1)

52-53: LGTM!

The peer dependency range ^18.2.0 || ^19.2.3 correctly allows consumers to use either React 18.2.0+ or React 19.2.3+. This aligns with the expanded test matrix that validates compatibility with both versions.

test-sites/pages-components-starter/scripts/test-matrix-local.sh (1)

13-13: LGTM!

The addition of React 19.2.3 to the local test matrix maintains consistency with the CI workflow, enabling developers to validate compatibility locally across both React versions.

.github/workflows/test-matrix.yml (1)

14-14: React 19.2.3 is valid and available on npm. The version was published on Dec 11, 2025, and is suitable for inclusion in the test matrix.

test-sites/pages-components-starter/package.json (1)

20-21: React 18 compatibility is already confirmed in the test site. Verification shows no deprecated APIs (ReactDOM.render), no problematic state patterns, and no hydration issues. The component uses modern React patterns and the Vite configuration is compatible with React 18.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants