Conversation
|
Can you please break out the style changes into a separate pull request? |
|
Ok, no problem, |
|
Yep – this just doesn't need to be a 2,000+ file change with over 39,000 changed lines. Happy to accept that kind of change, but separately. |
|
Hi I've founded a bug in updating unique slug (my fault!) fixed it and covered it with a test, for the refactor stuff I'm sorry but I don't have time to split in separate pull request... But as now the changes are not so many and your test are still passing, so hope it will not be to expensive for you to review them and eventually merge them... |
|
Hey @teone, apologies for losing track of this. I'm adding it to my "to review" list and will get back to you on this soon. |
Hi @yields, I've added a unique options to create unique slug in you plugin.
It's tested, any comment is highly appreciated 😄