Skip to content

Fix LinkPager::getPageRange when maxButtons assign with 2 #20538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix LinkPager::getPageRange when maxButtons assign with 2 #20538

wants to merge 3 commits into from

Conversation

max-s-lab
Copy link
Contributor

Q A
Is bugfix? ✔️
New feature? ❌
Breaks BC? ❌
Fixed issues #19655

@codecov Codecov
Copy link

codecov bot commented Sep 21, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.49%. Comparing base (de3bd9e) to head (13a13d5).

Additional details and impacted files 
@@            Coverage Diff            @@
##             master   #20538   +/-   ##
=========================================
  Coverage     64.49%   64.49%           
- Complexity    11571    11572    +1     
=========================================
  Files           433      433           
  Lines         37609    37610    +1     
=========================================
+ Hits          24256    24257    +1     
  Misses        13353    13353

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@terabytesoftw
Copy link
Member

I think it would be great to check all the content generated by the widgets in the tests, and thus know exactly what it generates. What do you think? I plan to adopt it in the tests for the 2.2 branch, and i think it would be great for the master branch, in addition to being cleaner in terms of style code.

$this->assertEqualsWithoutLE(
    <<<HTML
    <div class="form-group field-dynamicmodel-name">
    <input type="email" id="dynamicmodel-name" class="form-control" name="DynamicModel[name]" required>
    </div>
    HTML,
    (string) $form
        ->field($model, 'name', $o)
        ->input('email', ['required' => true]),
);

@max-s-lab
Copy link
Contributor Author

Good idea. I'll fix the added tests now.

Arhell
Arhell reviewed Sep 22, 2025
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terabytesoftw terabytesoftw terabytesoftw approved these changes

+1 more reviewer

@Arhell Arhell Arhell left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@max-s-lab @terabytesoftw @Arhell