Fusion: migrate colorbleed fork code #2752
Conversation
…tType don't exist in Py3+
This resolves an issue where otherwise `lib.imprint` will fail on `self.data` for this Creator plug-in
- Also refactor import maya.cmds as `mc` to `cmds` to match with other code in the OpenPype code base
- This fixes an issue with Maya 2022.0 where the maya web button was not yet renamed - Tested in Maya 2019.3.1, Maya 2020.4 and Maya 2022.1
- This fixes an issue with Maya 2022.0 where the maya web button was not yet renamed - Tested in Maya 2019.3.1, Maya 2020.4 and Maya 2022.1
…s currently thinks its operating
jakubjezek001
added
host: Fusion
type: enhancement
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| ) | ||
| print(LOAD_PATH) | ||
|
|
||
| pyblish.api.register_callback("instanceToggled", on_pyblish_instance_toggled) |
| try: | ||
| print("Qt library found, nothing to do.") | ||
| from Qt import QtWidgets | ||
| except ImportError as exc: |
There was a problem hiding this comment.
local variable 'exc' is assigned to but never used
|
|
||
| try: | ||
| print("Qt library found, nothing to do.") | ||
| from Qt import QtWidgets |
| " installed Python 3.6" | ||
| "Python 3.6 is not installed at the provided path: \n" | ||
| "Either make sure the 'environments/fusion.json' has " | ||
| "'PYTHON36' set correctly or make sure Python 3.6 is installed " |
| import os | ||
|
|
||
| from openpype.modules import OpenPypeModule | ||
| from openpype_interfaces import ( |
There was a problem hiding this comment.
'openpype_interfaces.ITrayModule' imported but unused
| # Get template key | ||
| #template_key = get_workfile_template_key_from_context( | ||
| # asset_name, task_name, host_name, project_name, dbcon | ||
| #) |
There was a problem hiding this comment.
block comment should start with '# '
|
|
||
| # todo: implement custom template keys instead of 'work' | ||
| # Get template key | ||
| #template_key = get_workfile_template_key_from_context( |
There was a problem hiding this comment.
block comment should start with '# '
| import getpass | ||
|
|
||
| from avalon import api, lib, pipeline | ||
| from avalon.vendor import six |
There was a problem hiding this comment.
'avalon.vendor.six' imported but unused
| import string | ||
| import getpass | ||
|
|
||
| from avalon import api, lib, pipeline |
There was a problem hiding this comment.
'avalon.lib' imported but unused
'avalon.pipeline' imported but unused
| @@ -0,0 +1,167 @@ | |||
| import os | |||
| import string | |||
|
Task linked: OP-2667 Fusion: set framerange from menu button |
|
The only real solution would be for me to extract these fusion changes more cleanly from our repo, no? Actually no. This currently DOES contain all the other changes. We should extract only the Fusion changes from our repo. Better ideas? This PR currently has changes that you will not want to merge in OpenPype. |
| print("Qt library found, nothing to do.") | ||
| from Qt import QtWidgets |
There was a problem hiding this comment.
I would do the print after import.
| print("Qt library found, nothing to do.") | |
| from Qt import QtWidgets | |
| from Qt import QtWidgets | |
| print("Qt library found, nothing to do.") |
| shutil.copy2(src, dst) | ||
| else: | ||
| shutil.copytree(src, dst) | ||
| __import__("avalon.fusion") |
There was a problem hiding this comment.
Module avalon.fusion does not exists anymore and it does not make sense to import it in prelaunch hook. Import of pyblish also does not make sense here.
I should have read this first. If you can cherry pick only commits that are fusion related then that would be best. But since it seems that it is combined I would suggest copy paste changes you want to merge and commit just that. You can commit changes in "reasonable chunks" so the commits make sense that's up to you. From my experience it is easier to copy and redo commits then cherry pick. Spend less time and nerves. |
Yes, that sounds about right. We could just take whatever is in the "Fusion" folder and other possible 'fusion related changes' and copy those changes over onto |
I could do it myself, but only that would be assigned ownership to myself which would not be fair. |
|
Thanks @jakubjezek001 - closing this in favor of #2769. Let me know if I forgot to include something important from your commits. |
Awesome, thanks @BigRoy - I was looking into #2769 and it seems to be having all of my changes regarding setFramerange. |
Brief description
Integrating Colorbleed's work and adding
Set Framerangeto menu items.Description
Original PR description here BigRoy#2
Set Framerangeto menu items to set framerange to comp from asset document data.