Skip to content
/ ifv Public
forked from banocean/ifv

Conversation

@yoper12
Copy link
Owner

@yoper12 yoper12 commented May 29, 2025

No description provided.

@yoper12 yoper12 requested a review from Copilot May 29, 2025 17:53
@yoper12 yoper12 self-assigned this May 29, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds consistent editor configuration for VS Code and hides specific dashboard tiles.

  • Introduce VS Code settings for Prettier formatting and auto-save formatting
  • Recommend EditorConfig, ESLint, and Prettier extensions
  • Update dashboard CSS to hide “lucky number” tile variants

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
patches/newDashboard/styles.css Hide .tile__lucky-number variants using :has and display: none
.vscode/settings.json Set Prettier as default formatter and enable format on save
.vscode/extensions.json Recommend EditorConfig, ESLint, and Prettier extensions
Comments suppressed due to low confidence (3)

patches/newDashboard/styles.css:45

  • The CSS :has() pseudo-class can be performance-intensive and is not fully supported across all browsers; consider using a dedicated class or data attribute on the parent element instead.
.tile.box:has(.lucky-number__circle.lucky-number__circle-1),

patches/newDashboard/styles.css:47

  • Avoid using !important, as it can create specificity conflicts and make future overrides harder; consider increasing selector specificity or toggling a utility class instead.
display: none !important;

patches/newDashboard/styles.css:44

  • Indentation for this selector is inconsistent with the following lines; consider aligning it with the 6-space indent used by the other selectors for better readability.
.tile.box.tile__lucky-number,

since it's in extensions.json
@yoper12 yoper12 merged commit 3cef5fa into main May 31, 2025
1 check failed
@yoper12 yoper12 deleted the linter branch May 31, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants