Changed banned players from ArrayList to HashSet#1
Open
zford wants to merge 1 commit intoyottabyte:masterfrom
zford:master
Open
Changed banned players from ArrayList to HashSet#1zford wants to merge 1 commit intoyottabyte:masterfrom zford:master
zford wants to merge 1 commit intoyottabyte:masterfrom
zford:master
Conversation
|
Is that a list of 'currently banned' or is it a list of 'every ban that has occurred'? Some users have can be banned more than once - temporary bans of course. |
Author
|
It's perma bans, and either way, KiwiAdmin definately doesn't allow you to ban a player twice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Banned players should contain no dupes, so Set is more appropriate than a List. Lookups should be faster faster on a HashSet compared to an ArrayList for large number of players.