Skip to content

Conversation

jenyyy4
Copy link
Contributor

@jenyyy4 jenyyy4 commented Oct 7, 2025

I added a loading spinner to the loading page and changed the background colour and font of text to make it look more appealing.

@aayush105
Copy link
Member

@jenyyy4

please provide me the output image and also in this pr you have of the 3d earth files as well so please it. I think you prev pr changes of 3d earth is also being committed in this pr.

@jenyyy4
Copy link
Contributor Author

jenyyy4 commented Oct 8, 2025

@aayush105

i tried removing the previous commit from this pr, but it's not working. can you please guide me on how to remove it? so sorry for the disturbance.

@aayush105
Copy link
Member

@aayush105

i tried removing the previous commit from this pr, but it's not working. can you please guide me on how to remove it? so sorry for the disturbance.

One method is like it would have been better to create a pr one at a time to resolve this type of issue and another is like for each pr make a separate branch and create a pr in this way it will be pr from 2 diff branches.

For now you can close this pr, pull the main branch for the latest update and then make your changes in the loading spinner and then create a pr.

@jenyyy4
Copy link
Contributor Author

jenyyy4 commented Oct 8, 2025

@aayush105
Copy link
Member

and also, here is the output recording: Uploading loading-after.mov…

no thing is seen here

@jenyyy4
Copy link
Contributor Author

jenyyy4 commented Oct 8, 2025

@aayush105
i tried removing the previous commit from this pr, but it's not working. can you please guide me on how to remove it? so sorry for the disturbance.

One method is like it would have been better to create a pr one at a time to resolve this type of issue and another is like for each pr make a separate branch and create a pr in this way it will be pr from 2 diff branches.

For now you can close this pr, pull the main branch for the latest update and then make your changes in the loading spinner and then create a pr.

Okay thank you so much, I'll make another pr right now.

@jenyyy4 jenyyy4 closed this Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants