Skip to content

cobalt: Add LevelDB errors to Local Storage UMA#10006

Open
zhongqiliang wants to merge 3 commits intoyoutube:mainfrom
zhongqiliang:UMA_FOR_LOCAL_STORAGE_RECREATE
Open

cobalt: Add LevelDB errors to Local Storage UMA#10006
zhongqiliang wants to merge 3 commits intoyoutube:mainfrom
zhongqiliang:UMA_FOR_LOCAL_STORAGE_RECREATE

Conversation

@zhongqiliang
Copy link
Copy Markdown
Contributor

@zhongqiliang zhongqiliang commented Apr 13, 2026

The previous UMA metrics for Local Storage recreate or reset events
did not provide specific error codes. This made it challenging to
diagnose the root causes of database issues.

This change introduces new UMA histograms to capture detailed LevelDB
error statuses when failures occur during Local Storage database open,
read operations, schema version checks, and commit operations. These
specific error codes will provide better insight into the reasons
behind database recreation attempts, improving debuggability and
monitoring.

Bug: 488465561

Change-Id: If0e6d33b3906f3964f888d1e2c7388e4c01f57ec
@github-actions
Copy link
Copy Markdown
Contributor

🤖 Gemini Suggested Commit Message


cobalt: Add LevelDB errors to Local Storage UMA

The previous UMA metrics for Local Storage recreate or reset events
did not provide specific error codes. This made it challenging to
diagnose the root causes of database issues.

This change introduces new UMA histograms to capture detailed LevelDB
error statuses when failures occur during Local Storage database open,
read operations, schema version checks, and commit operations. These
specific error codes will provide better insight into the reasons
behind database recreation attempts, improving debuggability and
monitoring.

Bug: 488465561

💡 Pro Tips for a Better Commit Message:

  1. Influence the Result: Want to change the output? You can write custom prompts or instructions directly in the Pull Request description. The model uses that text to generate the message.
  2. Re-run the Generator: Post a comment with: /generate-commit-message

Change-Id: I2c35cf07acde1740e513e57bb5584ce2154ecbf1
@zhongqiliang zhongqiliang changed the title a cobalt: Add LevelDB errors to Local Storage UMA Apr 13, 2026
@zhongqiliang zhongqiliang marked this pull request as ready for review April 13, 2026 21:13
@zhongqiliang zhongqiliang requested a review from a team as a code owner April 13, 2026 21:13
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several new UMA histograms to track LevelDB errors during database open, read, commit, and version mismatch operations in Local Storage. Feedback indicates that the DatabaseOpenError histogram is redundant because the status is already recorded elsewhere. Furthermore, the DatabaseVersionMismatch histogram currently logs an 'OK' status in all cases, so it should be replaced with a more descriptive metric type like a boolean or a specific mismatch enum.

Copy link
Copy Markdown
Contributor

@johnxwork johnxwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you verify that you can see the data locally with the script in cobalt/tools/ to pull UMA?

Change-Id: Iebdc64f9aeccd244a2ebfde747f72ced63b7361c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants