Cherry pick PR #9191: cobalt: Unify H5vccSettings processing#10023
Merged
Cherry pick PR #9191: cobalt: Unify H5vccSettings processing#10023
Conversation
This PR is to avoid repeated code by introducing helper methods Introduce a ProcessLongAs template helper to consolidate redundant V8 type checking and promise rejection logic for boolean settings. This streamlines the validation and conversion of V8UnionLongOrString values, simplifying H5vccSettings::set and ProcessDecoderBufferSettings. It also standardizes promise handling. Issue: 480134029 (cherry picked from commit 095d4ff)
Collaborator
Author
|
Caution There were merge conflicts while cherry picking! Check out cherry-pick-main-9191 and fix the conflicts before proceeding. Check the log at https://github.com/youtube/cobalt/actions/runs/24411079888 for details. |
Contributor
🤖 Gemini Suggested Commit Message💡 Pro Tips for a Better Commit Message:
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the H5vccSettings::set method by introducing template helpers for setting processing and adopting base::expected for error management. Review feedback highlights a missing LOG(WARNING) for unsupported DecoderBuffer. settings and recommends using constexpr constants instead of raw string literals to comply with Chromium style guidelines and maintain compile-time safety.
third_party/blink/renderer/modules/cobalt/h5vcc_settings/h_5_vcc_settings.cc
Show resolved
Hide resolved
third_party/blink/renderer/modules/cobalt/h5vcc_settings/h_5_vcc_settings.cc
Show resolved
Hide resolved
Contributor
johnedocampo
left a comment
johnedocampo
left a comment
There was a problem hiding this comment.
Overall, transfer from m114 to m138 looks good. Left some comments.
third_party/blink/renderer/modules/cobalt/h5vcc_settings/h_5_vcc_settings.cc
Outdated
Show resolved
Hide resolved
third_party/blink/renderer/modules/cobalt/h5vcc_settings/h_5_vcc_settings.cc
Show resolved
Hide resolved
Contributor
|
Is it also possible to update the PR description with a small list of differences between this CP and the original commit? Something like: |
Contributor
Make sense. Done |
kjyoun
approved these changes
Apr 14, 2026
johnedocampo
approved these changes
Apr 14, 2026
y4vor
approved these changes
Apr 14, 2026
cobalt-github-releaser-bot
added a commit
that referenced
this pull request
Apr 14, 2026
…ngs processing Refer to original PR: #10023 Refer to the original PR: #9191 This PR is to avoid repeated code by introducing helper methods Introduce a ProcessLongAs template helper to consolidate redundant V8 type checking and promise rejection logic for boolean settings. This streamlines the validation and conversion of V8UnionLongOrString values, simplifying H5vccSettings::set and ProcessDecoderBufferSettings. It also standardizes promise handling. Issue: 480134029 ---- Differences From The Original PR: - Added connection for DecommitableAllocatorStrategy. This makes cherry-picking #9462 unnecessary. - We cannot use `SettingContext` as the original commit does. main branch does not allow getting raw pointer to garbage-collectable memory - Help method takes a callback method returning boolean, since on main, we have to handle non-starboard build --------- Co-authored-by: Kyujung Youn <kjyoun@google.com> (cherry picked from commit d70c34a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refer to the original PR: #9191
This PR is to avoid repeated code by introducing helper methods
Introduce a ProcessLongAs template helper to consolidate
redundant V8 type checking and promise rejection logic for boolean
settings. This streamlines the validation and conversion of
V8UnionLongOrString values, simplifying H5vccSettings::set and
ProcessDecoderBufferSettings. It also standardizes promise handling.
Issue: 480134029
Differences From The Original PR:
SettingContextas the original commit does. main branch does not allow getting raw pointer to garbage-collectable memory