Cherry pick PR #9808: zlib: Fix GzipCompress invalid pointer crash#10024
Draft
cobalt-github-releaser-bot wants to merge 1 commit intomainfrom
Draft
Cherry pick PR #9808: zlib: Fix GzipCompress invalid pointer crash#10024cobalt-github-releaser-bot wants to merge 1 commit intomainfrom
cobalt-github-releaser-bot wants to merge 1 commit intomainfrom
Conversation
Collaborator
Author
|
Caution There were merge conflicts while cherry picking! Check out cherry-pick-main-9808 and fix the conflicts before proceeding. Check the log at https://github.com/youtube/cobalt/actions/runs/24411862760 for details. |
Contributor
🤖 Gemini Suggested Commit Message💡 Pro Tips for a Better Commit Message:
|
a3d1f66 to
5bce24c
Compare
GzipCompress crashed in a `CobaltMetricsLogUploaderTest` test due to a mismatched memory allocator issue. The initial buffer was allocated using base::UncheckedMalloc, which routes through PartitionAlloc. However, subsequent resizing attempted to use the system realloc(), causing a SIGABRT. This change avoids realloc() and correctly pairs base::UncheckedFree() with base::UncheckedMalloc() to resolve the invalid pointer abort. Bug: 486012022 Bug: 486003653
5bce24c to
e897998
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Refer to the original PR: #9808
GzipCompress crashed in a
CobaltMetricsLogUploaderTesttestdue to a mismatched memory allocator issue.
The initial buffer was allocated using base::UncheckedMalloc,
which routes through PartitionAlloc. However, subsequent resizing
attempted to use the system realloc(), causing a SIGABRT.
This change avoids realloc() and correctly pairs base::UncheckedFree()
with base::UncheckedMalloc() to resolve the invalid pointer abort.
Bug: 486012022
Bug: 486003653
Bug: 502259405