build: fix condition for removing NetworkChangeNotifier on hermetic builds#10028
Open
rogerzanoni wants to merge 1 commit intoyoutube:mainfrom
Open
build: fix condition for removing NetworkChangeNotifier on hermetic builds#10028rogerzanoni wants to merge 1 commit intoyoutube:mainfrom
rogerzanoni wants to merge 1 commit intoyoutube:mainfrom
Conversation
…tic builds
The base/network_change_notifier_linux.* files are added to the sources
only for linux builds, but should be removed for hermetic builds. Add
the same is_linux guard to check if the files should be removed from
source to fix the following gn gen issue:
ERROR at //net/BUILD.gn:1334:7: Item not found
"base/network_change_notifier_linux.cc"
Bug: 495203133
Contributor
🤖 Gemini Suggested Commit Message💡 Pro Tips for a Better Commit Message:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The base/network_change_notifier_linux.* files are added to the sources only for linux builds, but should be removed for hermetic builds. Add the same is_linux guard to check if the files should be removed from source to fix the following gn gen issue:
ERROR at //net/BUILD.gn:1334:7: Item not found
"base/network_change_notifier_linux.cc"
Bug: 495203133