evergreen: customize installation of updates

[yuying-y]

This change introduces logic to finalize installations using the Starboard
API and ensures proper cleanup of installation artifacts, such as drain
files, if unpacking fails. It also persists the installed Evergreen and
Starboard API versions, enabling better tracking of system state.

Issue: 479816505

[github-actions]

🤖 Gemini Suggested Commit Message

---

starboard: Integrate update installation via extension

Integrates the update client with the Starboard Installation Manager
Extension to handle platform-specific aspects of component updates.

This change introduces logic to finalize installations using the Starboard
API and ensures proper cleanup of installation artifacts, such as drain
files, if unpacking fails. It also persists the installed Evergreen and
Starboard API versions, enabling better tracking of system state.

Issue: 10036

---

💡 Pro Tips for a Better Commit Message:

1. Influence the Result: Want to change the output? You can write custom prompts or instructions directly in the Pull Request description. The model uses that text to generate the message.
2. Re-run the Generator: Post a comment with: /generate-commit-message

[gemini-code-assist]

Code Review

This pull request introduces Starboard-specific installation logic into the update_client component, enabling Cobalt slot management and version persistence. The review feedback highlights several critical issues regarding object lifetime management, specifically the need to use scoped_refptr for the ref-counted PersistedData object to avoid potential use-after-free errors in asynchronous tasks. Additionally, the Starboard implementation currently leaks the unpack_path directory, which must be addressed to prevent disk space exhaustion. There are also several style-related improvements needed to align with Chromium standards, such as using base::NumberToString and correcting indentation.

[gemini-code-assist]

Since PersistedData is a ref-counted object (base::RefCountedThreadSafe), it should be passed as a scoped_refptr<PersistedData> rather than a raw pointer. This ensures that the object remains alive during the asynchronous installation process.

             scoped_refptr<PersistedData> metadata,

[gemini-code-assist]

There are several issues in this block:

1. PersistedData is a ref-counted object. Using base::Unretained(metadata) in a PostTask is unsafe as metadata might be destroyed before the task executes. Passing it as a scoped_refptr ensures the object stays alive.
2. Chromium style prefers base::NumberToString over std::to_string for numeric conversions.

      if (metadata) {
        base::ThreadPool::PostTask(
            FROM_HERE, base::BindOnce(
              &PersistedData::SetLastInstalledEgAndSbVersion,
              metadata, id, next_version,
              base::NumberToString(SB_API_VERSION)));
      }

[gemini-code-assist]

The Starboard implementation of Install appears to leak the unpack_path directory. In the standard implementation (lines 215-240), a CallbackChecker is used to ensure that result.unpack_path is deleted after the installation completes. The Starboard path should also ensure this directory is cleaned up to avoid leaking disk space on every update.

[gemini-code-assist]

PersistedData is a ref-counted object (base::RefCountedThreadSafe). It should be passed as a scoped_refptr<PersistedData> rather than a raw pointer to ensure its lifetime is correctly managed across asynchronous boundaries.

    scoped_refptr<PersistedData> metadata,

[gemini-code-assist]

As noted in op_install.h, PersistedData should be passed as a scoped_refptr<PersistedData> to ensure proper lifetime management across the asynchronous pipeline operations.

Suggested change

	PersistedData* metadata,
	scoped_refptr<PersistedData> metadata,

[gemini-code-assist]

The indentation of the wrapped static_cast and its arguments does not follow the Chromium style guide (which uses 4 spaces for wrapped lines). Additionally, per Chromium style, auto* should be used for pointer types when the type is clear from the context.

      const auto* installation_api =
          static_cast<const CobaltExtensionInstallationManagerApi*>(
              SbSystemGetExtension(kCobaltExtensionInstallationManagerName));

[gemini-code-assist]

The indentation of the arguments for CobaltFinishInstallation is incorrect. Wrapped arguments should be aligned with the first argument or indented by 4 spaces relative to the start of the function call.

    } else if (CobaltFinishInstallation(
                   installation_api, crx_operation_result.installation_index,
                   result.unpack_path.value(), app_key)) {