Fix/new precommit githuh actions static checker#818
Fix/new precommit githuh actions static checker#818SortaCookie wants to merge 2 commits intoyoutube:mainfrom
Conversation
Change-Id: I634e14f3876bc17f9c10110a185673bfda392aca
Change-Id: I4038b7bf410fff437e461f63fd996cd6bcdba535
There was a problem hiding this comment.
Code Review
This pull request adds actionlint as a pre-commit hook to statically check GitHub Actions workflows. This is a great addition for improving workflow reliability. I've suggested a few changes to use the official actionlint repository and a more specific file pattern for better security, maintainability, and efficiency.
| - repo: https://github.com/SortaCookie/actionlint | ||
| rev: v1.7.7 | ||
| hooks: | ||
| - id: actionlint | ||
| files: ^.github/ |
There was a problem hiding this comment.
For better security and maintainability, it's recommended to use the official actionlint repository instead of a fork. The official repository is actively maintained and provides its own pre-commit support.
Additionally, the files pattern can be made more specific to only target workflow files within the .github/workflows directory. This prevents the hook from running unnecessarily on other files in the .github directory.
I've suggested using the latest official release from rhysd/actionlint and a more precise regex for matching workflow files.
- repo: https://github.com/rhysd/actionlint
rev: v1.7.1
hooks:
- id: actionlint
files: ^\.github/workflows/.*\.(?:ya?ml)$9482847 to
102fa36
Compare
ceb0ab6 to
0488ced
Compare
0488ced to
dea0857
Compare
918eec4 to
4dcdf5e
Compare
4dcdf5e to
93ce932
Compare
7ee6f43 to
9aa8e8b
Compare
9aa8e8b to
af1f59c
Compare
bc4fcf5 to
bb2b724
Compare
e2ea908 to
2a76b87
Compare
2a76b87 to
cb019c3
Compare
2dc2a50 to
4268187
Compare
4268187 to
081512e
Compare
097e9c9 to
c41cdd0
Compare
c41cdd0 to
7dc7279
Compare
7e6be1e to
7524b35
Compare
LABEL TESTER PLEASE IGORE