Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds smoke tests for Raspberry Pi and RDK platforms by updating the GitHub Actions workflow and configuration files. My review focuses on improving the maintainability and robustness of the workflow script and fixing a potential bug in the Python client script.
Key feedback points:
- The GCS archive path in the workflow is hardcoded, which will cause issues with future builds. It should be parameterized.
- The use of
evalin the workflow script is not ideal. A safer approach using bash arrays is recommended. - The Python script has a potential bug where it might send
cobalt_path=Nonewhen using the newgcs_archive_pathoption.
Libzu
requested review from
cvinish and
isarkis
and removed request for
andrewsavage1
isarkis
requested changes
Jan 6, 2026
isarkis
requested changes
Jan 9, 2026
Change-Id: I634e14f3876bc17f9c10110a185673bfda392aca
Libzu
force-pushed
the
add_smoke_tests
branch
from
69847d7 to
cb0c8e1
Compare
Contributor
Author
SortaCookie
force-pushed
the
main
branch
2 times, most recently
from
05ca899 to
9bca71e
Compare
copybara-service
bot
force-pushed
the
main
branch
from
9aa8e8b to
af1f59c
Compare
SortaCookie
force-pushed
the
main
branch
12 times, most recently
from
b06b7d4 to
3b23a8d
Compare
copybara-service
bot
force-pushed
the
main
branch
from
3b23a8d to
44ed002
Compare
SortaCookie
force-pushed
the
main
branch
9 times, most recently
from
e2ea908 to
2a76b87
Compare
copybara-service
bot
force-pushed
the
main
branch
from
2a76b87 to
cb019c3
Compare
SortaCookie
force-pushed
the
main
branch
6 times, most recently
from
851a3b7 to
2dc2a50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI: Add Smoke Tests for Raspberry Pi and RDK
This change enables the execution of smoke tests for Raspberry Pi (raspi) and RDK platforms. It integrates these tests into the existing
internal_testsGitHub Action workflow. Configuration for these platforms has been updated in the respective JSON files. Theon_device_tests_gateway_client.pyscript has been modified to support these tests.Bug: 470180018