feat: 给numberInput组件增加dynamicDecimal属性，支持用户保留完整的小数位数 #1945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpylua
suggested changes
Apr 20, 2022
Contributor
cpylua
left a comment
cpylua
left a comment
There was a problem hiding this comment.
搜一下用到 decimal 这个 props 的地方，我感觉有遗漏的地方，没这么简单。
Comment on lines
112
to
114
| decimalPlaces === DYNAMIC_DECIMAL_SIGN | ||
| ? getDecimalsLength(decimal) | ||
| : decimalPlaces |
Contributor
There was a problem hiding this comment.
- 如果觉得有遗漏的地方，需要提出具体哪里遗漏
getDecimalsLength这个方法，如果只有这个地方用到，我是建议保持现状，职责单一
| } | ||
|
|
||
| // 表示小数点位数取用户实际输入的小数点位数 | ||
| const DYNAMIC_DECIMAL_SIGN = -1; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes you made in this pull request: