Update S-series registers, extensions, coil groups#231
Open
vtamm wants to merge 5 commits intoyozik04:masterfrom
Open
Update S-series registers, extensions, coil groups#231vtamm wants to merge 5 commits intoyozik04:masterfrom
vtamm wants to merge 5 commits intoyozik04:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #231 +/- ##
==========================================
+ Coverage 70.19% 70.34% +0.14%
==========================================
Files 14 14
Lines 1359 1359
==========================================
+ Hits 954 956 +2
+ Misses 405 403 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vtamm
changed the title
Owner
|
I am OK with these changes. @elupus, I am not very familiar with coil groups (I still use MQTT service instead of HA integration because of some dependencies). Does PR look fine for you? If yes, feel free to click merge. |
elupus
reviewed
May 24, 2025
Collaborator
There was a problem hiding this comment.
These changes look incorrect. The files added does not like up with the descriptions.
elupus
reviewed
May 24, 2025
Collaborator
There was a problem hiding this comment.
These should be fine i think.
Collaborator
|
Most things are linked to https://headless.nibe.eu/download/18.3bd9d98318c457ffd811678/1703680919076/M12676EN2.pdf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Please select the type of your PR:
Description
Heatpump model: S1256
Firmware version: 4.2.4
s1156_s1256.csvand converted the updated CSV to JSON with the provided scriptextensions.jsonChecklist