Open
Conversation
+ The minimun-height element was removed from '.body' because it was being applied to the menu also, making it much longer than necessary; ie. a huge amount of whitespace.
+ skin 'hacker-style' has been renamed to 'green-skin' + a new css id needed to be created because the green-skin css for the h2 tag was inconsistent between the cookies and options pages. + I'm not knowledgeable enough in javascript to figure out why the menu.html isn't yet applying the skin changes; however, manually uncommenting the css import line in that file shows that the result would be pretty.
Owner
|
Hi, thank you for your PR, i will test this as soon as possible ;) |
Author
|
Just to be clear, I did figure out that the current branch was fpi, not master, ad did base my work on the fpi branch, so that shouldn't be an obstacle to merging the pull request. |
Juanepaktho
approved these changes
Dec 21, 2020
|
@ysard Have you tested this yet? (In 2019 you wrote you will test it asap #53 (comment) ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per our prior discussion, here's a pull request that adds:
An option for a dark theme
Renaming the 'hacker-style' theme to plain 'green'
Javascript for dynamic updating of the themes
Removing hard-coded css from html files, and combining themm into an individual theme file.
Minor css label changes, and additions, to handle conflicts among the css of the individual html files.
IMPORTANT: I'm not knowledgeable enough in javascript to figure out why the
menu.html isn't yet applying the skin changes; however, manually
uncommenting the css import line in that file shows that the result
would be pretty. The theme changes do work fine for cookies.html and options.html files