Correct sample text in Editors.tsx #365
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the CodeMirror `options=` value up to underneath the strategy value, to match the other examples. This makes it more consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit f5d85bd:
To be in line with correct grammar, the phrase should be either "This is a sample." or "This is sample text.". The first option makes it a noun, the second makes it an adjective. Judging from the surrounding context, the former was chosen.
Commit 97b031c:
Moved the CodeMirror
options=value up to underneath the strategy value, to match the other examples. This makes it more consistent.This should not impact anything but the visual readability of the code file in the background. 't is just nice etiquette.