fix(selene): exclude .dependencies directory from linting#57
Conversation
Summary of ChangesHello @yuys13, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the project's linting setup by configuring the Selene linter to ignore external dependency files. This adjustment streamlines the development process by focusing linting efforts solely on the project's proprietary code, preventing irrelevant warnings or errors from third-party libraries. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Code Review
This pull request correctly identifies the need to exclude the .dependencies directory from linting by Selene. However, the glob pattern used can be made more robust. I've suggested a small change to ensure all subdirectories and files within the dependencies folder are recursively excluded, which will prevent potential future linting issues with nested dependencies.
1d7b318 to
b6176c6
Compare
Code Metrics Report
Details | | main (77228cf) | #57 (62b8972) | +/- |
|---------------------|----------------|---------------|------|
| Coverage | 63.4% | 63.4% | 0.0% |
| Files | 6 | 6 | 0 |
| Lines | 208 | 208 | 0 |
| Covered | 132 | 132 | 0 |
- | Test Execution Time | 0s | 1s | +1s |Reported by octocov |
Exclude .dependencies directory from selene linting to avoid reporting errors in external dependencies. This ensures that only the project's own code is checked.