Skip to content

fix(selene): exclude .dependencies directory from linting#57

Merged
yuys13 merged 1 commit intomainfrom
fix/selene-exclude-deps
Feb 11, 2026
Merged

fix(selene): exclude .dependencies directory from linting#57
yuys13 merged 1 commit intomainfrom
fix/selene-exclude-deps

Conversation

@yuys13
Copy link
Owner

@yuys13 yuys13 commented Feb 11, 2026

Exclude .dependencies directory from selene linting to avoid reporting errors in external dependencies. This ensures that only the project's own code is checked.

@gemini-code-assist
Copy link

Summary of Changes

Hello @yuys13, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the project's linting setup by configuring the Selene linter to ignore external dependency files. This adjustment streamlines the development process by focusing linting efforts solely on the project's proprietary code, preventing irrelevant warnings or errors from third-party libraries.

Highlights

  • Linting Configuration: The Selene linter configuration has been updated to exclude the .dependencies directory from its checks.
  • Improved Linting Focus: This change ensures that Selene only reports issues within the project's own codebase, avoiding errors from external dependencies.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • selene.toml
    • Added an exclude rule to prevent linting of the .dependencies directory.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions

This comment has been minimized.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly identifies the need to exclude the .dependencies directory from linting by Selene. However, the glob pattern used can be made more robust. I've suggested a small change to ensure all subdirectories and files within the dependencies folder are recursively excluded, which will prevent potential future linting issues with nested dependencies.

@yuys13 yuys13 force-pushed the fix/selene-exclude-deps branch from 1d7b318 to b6176c6 Compare February 11, 2026 10:09
@github-actions
Copy link

Code Metrics Report

main (77228cf) #57 (62b8972) +/-
Coverage 63.4% 63.4% 0.0%
Test Execution Time 0s 1s +1s
Details
  |                     | main (77228cf) | #57 (62b8972) | +/-  |
  |---------------------|----------------|---------------|------|
  | Coverage            |          63.4% |         63.4% | 0.0% |
  |   Files             |              6 |             6 |    0 |
  |   Lines             |            208 |           208 |    0 |
  |   Covered           |            132 |           132 |    0 |
- | Test Execution Time |             0s |            1s |  +1s |

Reported by octocov

@yuys13 yuys13 merged commit a2ff690 into main Feb 11, 2026
11 checks passed
@yuys13 yuys13 deleted the fix/selene-exclude-deps branch February 11, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant