chore(container): drop vestigial local fallback, use sys.modules-alias bridge#236
Open
ywatanabe1989 wants to merge 1 commit intodevelopfrom
Open
chore(container): drop vestigial local fallback, use sys.modules-alias bridge#236ywatanabe1989 wants to merge 1 commit intodevelopfrom
ywatanabe1989 wants to merge 1 commit intodevelopfrom
Conversation
…s bridge scitex-container has lived as a standalone package since v0.1.6, and the local fallback in scitex.container/__init__.py (with copies of _build.py, _freeze.py, _status.py, _utils.py, _versioning.py) was only kept as a defensive try/except branch. The fallback drifted from the standalone implementation and was effectively unused — every install of scitex pulls scitex-container as an extra. Drop the local copies and rewrite scitex.container/__init__.py as the standard sys.modules alias used by all other extracted modules (scitex.linalg/git/events/security/msword/datetime/context/cv/template). The [container] extra is bumped to >=0.1.6. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`scitex.container` has been delegated to the standalone scitex-container package since v0.1.6, but the umbrella kept a local fallback (`_build.py`, `_freeze.py`, `_status.py`, `_utils.py`, `_versioning.py`) inside a `try/except ImportError` branch. That fallback drifted from the standalone implementation and is effectively dead code.
This PR aligns `scitex.container` with the pattern used by all other extracted modules: a thin `sys.modules` alias to `scitex_container`. The `[container]` extra is bumped to `>=0.1.6`.
Test plan
🤖 Generated with Claude Code