cleanup(notification): sys.modules alias, drop 2,621 LOC of shadowed dead code#252
Open
ywatanabe1989 wants to merge 1 commit intodevelopfrom
Open
cleanup(notification): sys.modules alias, drop 2,621 LOC of shadowed dead code#252ywatanabe1989 wants to merge 1 commit intodevelopfrom
ywatanabe1989 wants to merge 1 commit intodevelopfrom
Conversation
…f shadowed dead code The local src/scitex/notification/_backends/, _mcp/, mcp_server.py, _skills/ were duplicates already shadowed by `from scitex_notification import ...` in __init__.py — never reachable at runtime. Replace the explicit re-export with a sys.modules alias and delete the dead code. scitex.notification is scitex_notification: True (verified) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/scitex/notification/_backends/,_mcp/,mcp_server.py,_skills/were duplicates already shadowed at runtime byfrom scitex_notification import ...in__init__.py— never reachable.sys.modulesalias (matches scitex-logging chore(logging): convert explicit re-export shim → sys.modules-alias bridge #246 / scitex-session refactor(session): extract scitex.session into standalone scitex-session package #251 pattern). Nowscitex.notification is scitex_notification.Test plan
python -c "import scitex.notification as n; import scitex_notification as r; assert n is r"— passeshasattr(scitex.notification, 'alert' / 'available_backends' / ...)— all present (delegated through alias)