extract(nn): scitex.nn → scitex-nn v0.1.0 (2,664 LOC, 458 tests pass)#254
Open
ywatanabe1989 wants to merge 1 commit intodevelopfrom
Open
extract(nn): scitex.nn → scitex-nn v0.1.0 (2,664 LOC, 458 tests pass)#254ywatanabe1989 wants to merge 1 commit intodevelopfrom
ywatanabe1989 wants to merge 1 commit intodevelopfrom
Conversation
scitex.nn (2,664 LOC, neural-network blocks) extracted to standalone scitex-nn package: https://github.com/ywatanabe1989/scitex-nn - Replace src/scitex/nn/ with 12-line sys.modules-alias __init__.py - Collapse [nn] extra (9 transitive deps) to single scitex-nn>=0.1.0 - scitex.nn is scitex_nn: True (verified) - Standalone tests: 458 pass / 2 fail (flaky FreqGainChanger random) / 38 skip Decoupling in scitex-nn: - scitex.{decorators,gen} → scitex_decorators / scitex_gen direct imports - scitex.dsp.utils helpers vendored under _vendor_dsp_utils/ with prefer-real fallback - scitex.nn.X self-references → scitex_nn.X Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scitex.nn(2,664 LOC, neural-network blocks: BNet, Hilbert, PAC, Wavelet, Filters, …) to standalone scitex-nn v0.1.0.src/scitex/nn/with 12-linesys.modulesalias.[nn]extra from 9 transitive deps → singlescitex-nn>=0.1.0.Decoupling (in scitex-nn)
scitex.{decorators,gen}→scitex_decorators/scitex_gendirect imports (now both standalone via refactor(decorators): extract scitex.decorators into standalone scitex-decorators package #237 / extract(gen): scitex.gen → scitex-gen v0.1.0 (3,365 LOC, 604 tests pass) #253).scitex.dsp.utils(build_bandpass_filters, init_bandpass_filters, ensure_3d, ensure_even_len, zero_pad, design_filter) → vendored under_vendor_dsp_utils/. The vendor prefers the realscitex.dsp.utilswhen the umbrella is installed (lockstep) and falls back to the vendored copy when scitex_nn runs standalone.scitex.nn.Xself-references →scitex_nn.X.Test plan
python -c "import scitex.nn as n; import scitex_nn as r; assert n is r"— passeshasattr(scitex.nn, 'Hilbert' / 'PAC' / 'Wavelet' / ...)— presentDepends on
scitex_gen._to_even / _to_oddare direct imports in scitex-nn now.