cleanup(dt): drop shadowed _linspace.py / _normalize_timestamp.py dead code#256
Open
ywatanabe1989 wants to merge 1 commit intodevelopfrom
Open
cleanup(dt): drop shadowed _linspace.py / _normalize_timestamp.py dead code#256ywatanabe1989 wants to merge 1 commit intodevelopfrom
ywatanabe1989 wants to merge 1 commit intodevelopfrom
Conversation
scitex.dt is a backward-compat alias of scitex.datetime — its __init__.py imports everything from scitex.datetime, leaving the local _linspace.py and _normalize_timestamp.py shadowed dead code (verified: no module reads them by direct path). Drop them along with the empty _skills/ dir. Verified: hasattr(scitex.dt, 'linspace' / 'to_datetime') == True. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scitex.dtinit.py is a thin alias ofscitex.datetime— re-exports everything viafrom scitex.datetime import ...._linspace.py/_normalize_timestamp.pyare shadowed at runtime and have no direct-path callers (verified:grep -r 'scitex.dt._linspace'finds nothing)._skills/dir.scitex.dt.linspace/.to_datetimecontinue to work via the alias.Test plan
from scitex import dt; assert hasattr(dt, 'linspace') and hasattr(dt, 'to_datetime')— passes