Fix before_filter > before_action deprecation error (backward compatible) #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Can anyone code-review and merge, please? |
uzairfaisal
suggested changes
Sep 14, 2018
uzairfaisal
left a comment
uzairfaisal
left a comment
There was a problem hiding this comment.
Is this gem no longer being maintained?
| @@ -1,3 +1,8 @@ | |||
| 2.0.0 | |||
There was a problem hiding this comment.
I don't think there's any major incompatible API changes ... maybe better to stick to 1.9.0?
|
I would love for this to get merged. @zachinglis |
uzairfaisal
suggested changes
Jul 23, 2019
uzairfaisal
left a comment
uzairfaisal
left a comment
There was a problem hiding this comment.
From code review only, this looks alright - just needs the correct version bump.
| @@ -1,6 +1,6 @@ | |||
| module Crummy | |||
| MAJOR = 1 | |||
There was a problem hiding this comment.
I see the breaking change (removing ruby 1.9 support) - in that case, this should be:
Suggested change
| MAJOR = 1 | |
| MAJOR = 2 | |
| MINOR = 0 | |
| PATCH = 0 |
|
I made a fork https://github.com/rubynetti/crummy with support for rails 5.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.