Add multi-provider support with model selection and custom model input#43
Open
xROBERTINOx wants to merge 1 commit intozachlatta:mainfrom
Open
Add multi-provider support with model selection and custom model input#43xROBERTINOx wants to merge 1 commit intozachlatta:mainfrom
xROBERTINOx wants to merge 1 commit intozachlatta:mainfrom
Conversation
Owner
|
Can you make a video showing this full new process working and successfully transcribing audio? |
Owner
|
Thanks for this awesome PR! Excited to see your video |
|
@zachlatta shall we get this merged? I think everything is working good. The video could be a bit of overhead, but if one spins the branch locally - it's possible to test for regressions and see that everything is good |
Owner
|
Yes, I'm eager to get this merged! I'd like @xROBERTINOx to make a video (or someone else) to make a video showing the full thing works because this is a big PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Inspired by #36 — rebuilt from scratch on top of the current main branch to avoid merge conflicts.
Setup Flow
Provider Selection:
Provider-Aware API Key:
Model Selection with Descriptions:
Settings
Provider & Model Settings:
Files Changed
Sources/APIProvider.swift— Provider enum with model lists, descriptions, URLs, and custom model supportSources/SetupView.swift— Added provider and model selection steps to setup wizardSources/AppState.swift— Added custom model ID storage, effective model ID resolution, per-provider key storageSources/SettingsView.swift— Updated provider picker (dropdown) and model section (radio buttons with descriptions)Sources/TranscriptionService.swift— Accepts model as constructor parameterSources/PostProcessingService.swift— Accepts model as constructor parameterSources/AppContextService.swift— Accepts model as constructor parameter