This repository was archived by the owner on Dec 8, 2023. It is now read-only.
Add a fallback for loading files, and cache them.#2
Open
tplaindoux wants to merge 1 commit intozachsnow:masterfrom
Open
Add a fallback for loading files, and cache them.#2tplaindoux wants to merge 1 commit intozachsnow:masterfrom
tplaindoux wants to merge 1 commit intozachsnow:masterfrom
Conversation
Owner
|
The idea for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is one issue remaining:
When loading files on an ng-repeat, template will be called multiples time and fire multiple http requests.
The only workaround I can see for this is to pre-load the template we will use into ng-repeat. This way the will only be loaded once. This is not needed for normal / singles ng-inline.