Skip to content
This repository was archived by the owner on Dec 8, 2023. It is now read-only.

Add a fallback for loading files, and cache them.#2

Open
tplaindoux wants to merge 1 commit intozachsnow:masterfrom
tplaindoux:master
Open

Add a fallback for loading files, and cache them.#2
tplaindoux wants to merge 1 commit intozachsnow:masterfrom
tplaindoux:master

Conversation

@tplaindoux
Copy link
Copy Markdown

There is one issue remaining:

When loading files on an ng-repeat, template will be called multiples time and fire multiple http requests.
The only workaround I can see for this is to pre-load the template we will use into ng-repeat. This way the will only be loaded once. This is not needed for normal / singles ng-inline.

@zachsnow
Copy link
Copy Markdown
Owner

The idea for ng-inline is that you must put provide them in the cache, so indeed you should pre-load the template via <script type="text/ng-template" /> (or any other method). Loading them externally defeats somewhat the goal of fast compilation, though I can see the use-case. I'll have a look too.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants