Allow layout on CPU even if valid cuda GPU exists#206
Open
Rushmore75 wants to merge 1 commit intozai-org:mainfrom
Open
Allow layout on CPU even if valid cuda GPU exists#206Rushmore75 wants to merge 1 commit intozai-org:mainfrom
Rushmore75 wants to merge 1 commit intozai-org:mainfrom
Conversation
…e still need to make sure the value isn't cpu
Collaborator
|
can u add a relevant unit test for it? @Rushmore75 |
Author
|
I'm not sure how I would make a test for it, since the test would have to run on a CI machine with cuda capabilities |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there is a valid cuda gpu and you had set
cuda_visible_devices, previously it would error out trying to put the model oncuda:cpu. This is now fixed where if you setcuda_visible_devicestocpuit correctly loads the model onto the cpu :)