feat(opts): add missing DBOptions::allow_fallocate#204
Draft
Nytelife26 wants to merge 1 commit intozaidoon1:masterfrom
Draft
feat(opts): add missing DBOptions::allow_fallocate#204Nytelife26 wants to merge 1 commit intozaidoon1:masterfrom
Nytelife26 wants to merge 1 commit intozaidoon1:masterfrom
Conversation
This is required for maintaining performant deployments on CoW filesystems, such as btrfs, where preallocated chunks that do not get used are never freed.
Owner
|
can you add a test to call this function, set it to false, do some writes, etc.. just to make sure it's all good |
Author
|
Yes, I will. I just noticed, however, that the corresponding function is not yet exposed in RocksDB itself, so I'm going to have to make a PR there, which will block this until its completion. |
Author
|
This is now blocked on github.com:facebook/rocksdb#14400, so I will revisit adding tests after that is merged. |
zaidoon1
force-pushed
the
master
branch
4 times, most recently
from
55d2f46 to
b551214
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Blocked on github.com:facebook/rocksdb#14400.
Brief
This is required for maintaining performant deployments on some CoW filesystems, such as btrfs, where preallocated chunks that do not get used are never freed.
References