Add IngestExternalFileOptions AsRawPtr impl#206
Merged
zaidoon1 merged 1 commit intozaidoon1:masterfrom Mar 19, 2026
Merged
Conversation
Owner
|
this looks good over all, but please add tests to make sure we won't panic or anything when using this for whatever use case you have. |
Contributor
Author
|
Added a test case that validates the use of the raw ptr (as well as basic pointer stability tests similar to the other tests in that module) |
zaidoon1
force-pushed
the
ingestfileoptions-rawptr
branch
from
d9ca339 to
be38a2d
Compare
zaidoon1
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.