Skip to content

Conversation

Juneezee
Copy link

These experimental packages are now available in the Go standard library since Go 1.21.

  1. golang.org/x/exp/slices -> slices (https://go.dev/doc/go1.21#slices)
  2. golang.org/x/exp/maps -> maps (https://go.dev/doc/go1.21#maps)

These experimental packages are now available in the Go standard
library since Go 1.21.

	1. golang.org/x/exp/slices -> slices [1]
	2. golang.org/x/exp/maps -> maps [2]

[1]: https://go.dev/doc/go1.21#slices
[2]: https://go.dev/doc/go1.21#maps

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
@FxKu FxKu moved this to Good state for merge in Postgres Operator Jul 15, 2025
@idanovinda
Copy link
Member

👍

1 similar comment
@FxKu
Copy link
Member

FxKu commented Sep 17, 2025

👍

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
@zalando-robot
Copy link

Cannot start a pipeline due to:

No accountable user for this pipeline: no Zalando employee associated to this GitHub username

Click on pipeline status check Details link below for more information.

@Juneezee
Copy link
Author

Hi @FxKu, the previous E2E job run failed, but it looks like a flaky error. Could you please trigger the CI job again? Thanks

https://github.com/zalando/postgres-operator/actions/runs/17800579342/job/50610445500#step:7:1076

======================================================================
FAIL: test_enable_disable_connection_pooler (test_e2e.EndToEndTestCase)
For a database without connection pooler, then turns it on, scale up,
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/local/lib/python3.8/dist-packages/timeout_decorator/timeout_decorator.py", line 82, in new_function
    return function(*args, **kwargs)
  File "/tests/test_e2e.py", line 776, in test_enable_disable_connection_pooler
    self.eventuallyEqual(lambda: k8s.get_deployment_replica_count(), 2,
  File "/tests/test_e2e.py", line 43, in eventuallyEqual
    self.assertEqual(y, x, m.format(y))
AssertionError: None != 2 : Deployment replicas is 2 default

@Juneezee
Copy link
Author

@FxKu Another flaky error. Please re-run the job again. Thanks 🙏

https://github.com/zalando/postgres-operator/actions/runs/17815054746/job/50690620177?pr=2857#step:7:1724

======================================================================
FAIL: test_multi_namespace_support (test_e2e.EndToEndTestCase)
Create a customized Postgres cluster in a non-default namespace.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/local/lib/python3.8/dist-packages/timeout_decorator/timeout_decorator.py", line 82, in new_function
    return function(*args, **kwargs)
  File "/tests/test_e2e.py", line 1467, in test_multi_namespace_support
    k8s.wait_for_pod_start("spilo-role=master", self.test_namespace)
  File "/tests/k8s_api.py", line 107, in wait_for_pod_start
    time.sleep(self.RETRY_TIMEOUT_SEC)
  File "/usr/local/lib/python3.8/dist-packages/timeout_decorator/timeout_decorator.py", line 69, in handler
    _raise_exception(timeout_exception, exception_message)
  File "/usr/local/lib/python3.8/dist-packages/timeout_decorator/timeout_decorator.py", line 45, in _raise_exception
    raise exception()
timeout_decorator.timeout_decorator.TimeoutError: 'Timed Out'

@Juneezee
Copy link
Author

Juneezee commented Sep 18, 2025

@FxKu @idanovinda The tests finally passed! This PR requires two more approvals again. Would you mind re-approving it when you have some time? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Good state for merge
Development

Successfully merging this pull request may close these issues.

4 participants