-
-
Notifications
You must be signed in to change notification settings - Fork 366
Add more redirects for sphinx->mkdocs migration #3544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I'm not able to request reviews from you, but FYI @ilan-gold @ianhi |
|
Commented here @maxrjones but I think the check (in |
Can you please provide an example of an intersphinx link that is still broken following the changes in this PR? |
Apologies, I should have been clearer. I wasn't commenting on how well this fixes things, more just responding to what Davis said about checking URLs directly. I think the unit of interest shouldn't be the actual URLs but the intersphinix lookup i.e., the later should be checked. I try to avoid using URLs for exactly that reason - they can change but intersphinx allows us to keep the location in the reference the same over that. That being, here's what I got locally against https://zarr--3544.org.readthedocs.build/en/3544/: UPDATE: tried remotely as well: https://app.readthedocs.org/projects/annbatch/builds/30070579/ |
This PR aims to address #3542.
TODO:
docs/user-guide/*.mdchanges/