Open
Conversation
Author
|
I tested this like: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes:
You were setting the genesis block (0) as its own parent, I removed this as it borks the cohort algorithm. It doesn't seem to affect your code otherwise.
I had to compute the children array, which is just a reversal of direction on the parents array.
next_generationis a generalization of both that allows traversal of the graph from genesis to tip or backwards from tip to genesis.int/nb.int32 differences don't seem to have any impact but I can force it to use np.int32 if you want.
I didn't use this
cohorts()function anywhere, just providing its definition here so you can use it instead of a correction factor.Use this like: