Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
simplewish | e0464bf | Feb 03 2026, 12:36 AM |
There was a problem hiding this comment.
Pull request overview
Updates the CI container images to use Alpine-based Python images instead of Debian slim, aligning package management and user/shell setup with Alpine.
Changes:
- Switched CI images from
python:3.14-slimtopython:3.14-alpine(builder + runtime stages). - Replaced
apt-getdependency installation withapkequivalents. - Updated shell and non-root user creation commands for Alpine (
/bin/sh,addgroup/adduser).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/ci/Dockerfile.qr | Migrates QR CI image to Alpine base and updates system deps/user setup accordingly. |
| .github/ci/Dockerfile.infra | Migrates infra CI image to Alpine base and updates system deps/user setup accordingly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| RUN apk add --no-cache --virtual .build-deps \ | ||
| build-base \ | ||
| libffi-dev \ | ||
| libssl-dev \ | ||
| pkg-config \ | ||
| libc6-dev \ | ||
| openssl-dev \ | ||
| pkgconfig \ | ||
| && python -m pip install --upgrade pip setuptools==80.10.2 wheel \ | ||
| && rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/* | ||
| && apk del .build-deps \ | ||
| && rm -rf /tmp/* /var/tmp/* |
There was a problem hiding this comment.
The virtual .build-deps packages are installed and removed in this layer before the requirements are installed, so they won't be available if any dependency needs compilation during pip install -r .... Consider keeping .build-deps around until after the requirements install (same RUN), or remove the build deps entirely if they’re unnecessary for this image.
| RUN apk add --no-cache --virtual .build-deps \ | ||
| build-base \ | ||
| libffi-dev \ | ||
| libssl-dev \ | ||
| pkg-config \ | ||
| libc6-dev \ | ||
| openssl-dev \ | ||
| pkgconfig \ | ||
| && python -m pip install --upgrade pip setuptools==80.10.2 wheel \ | ||
| && rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/* | ||
| && apk del .build-deps \ | ||
| && rm -rf /tmp/* /var/tmp/* |
There was a problem hiding this comment.
The virtual .build-deps packages are installed and removed in this layer before the pip install -r /tmp/requirements.txt step runs, so they don't actually help with building any wheels during dependency installation. Either (a) move apk del .build-deps to after the requirements install (ideally in the same RUN to keep the layer small), or (b) drop the build deps entirely if you intend to only install pure-Python deps here.
No description provided.