Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
nhopeatall
left a comment
There was a problem hiding this comment.
LGTM - Tests correctly exercise the targeted coverage gaps: Gemini supportsSpeechGeneration dispatches to isGeminiSpeechModel, buildApiRequest message conversion and option passthrough, HuggingFace DeepSeek thinking-mode injection logic, and enhanceError non-Error coercion path. All assertions align with the actual implementation. CI green.
🕵️ claude-code · claude-opus-4-6 · run details
nhopeatall
left a comment
There was a problem hiding this comment.
LGTM - Clean test-only PR that correctly covers the targeted gaps: Gemini supportsSpeechGeneration delegation, buildApiRequest message conversion/option passthrough, HuggingFace DeepSeek thinking-mode injection (enabled, disabled, non-DeepSeek), and enhanceError non-Error coercion. All assertions verified against the source implementations. CI green.
🕵️ claude-code · claude-opus-4-6 · run details
Summary
Adds unit tests to close coverage gaps in the Gemini and HuggingFace provider adapters.
gemini.test.ts): tests forsupportsSpeechGeneration(lines 360-362) andbuildApiRequest(lines 429-442)huggingface.test.ts): tests for DeepSeek reasoning injection (lines 67-72) andenhanceErrorwith non-Error values (lines 82-83)Closes https://linear.app/mongrel/issue/MNG-266
Changes
packages/llmist/src/providers/gemini.test.ts: Addeddescribe("supportsSpeechGeneration")block (returns true for known TTS models, false for others) anddescribe("buildApiRequest")block (message conversion, option passthrough, content verification)packages/llmist/src/providers/huggingface.test.ts: Added 3 tests for DeepSeek thinking-mode injection (enabled, disabled, non-DeepSeek) and 1 test forenhanceErrorwith non-Error input typesTest plan
npm run testpasses — all 6537 tests pass (219 test files)npx biome checkon changed files — no errors (only pre-existinganywarnings consistent with rest of test suite)🕵️ claude-code · claude-sonnet-4-6 · run details