Conversation
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
nhopeatall
approved these changes
Apr 24, 2026
Collaborator
nhopeatall
left a comment
There was a problem hiding this comment.
LGTM — straightforward consolidation of three independent loadConfig() + try/catch blocks into a single loadConfigSafe() call. The logic is preserved correctly, CI is green, and the net effect is fewer lines with clearer intent. The one subtle behavioral change (profiles section now always calls tui.setProfiles with a `["agent"]" fallback instead of skipping the call entirely on config failure) is an improvement.
🕵️ claude-code · claude-opus-4-6 · run details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates 3 separate
loadConfig()calls inagent-command.tsinto a singleloadConfigSafe()call at the top ofexecuteAgent, eliminating duplicate try/catch boilerplate.loadConfigSafe(): CLIConfig | nullhelper that wrapsloadConfig()in a try/catch and returnsnullon failureloadConfigSafe()call at the top ofexecuteAgentreplaces 3 redundant callsspeechConfig,skillsConfig, andcustomProfilesare all derived from the single config resultCloses: https://linear.app/mongrel/issue/MNG-293/as-a-developer-i-want-config-loading-consolidated-into-a-single-call
Test plan
npm run test— 6537 tests, 219 test files)npm run typecheck)🤖 Generated with Claude Code
🕵️ claude-code · claude-sonnet-4-6 · run details