docs(openrpc): Use common crate for openrpc functionality #353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
str4d
reviewed
Dec 18, 2025
| } | ||
|
|
||
| /// Static information about a Zallet JSON-RPC method. | ||
| pub(super) struct RpcMethod { |
Collaborator
There was a problem hiding this comment.
Given that all of this code was authored by me and copied into the openrpsee crate, I would appreciate if my authorship credit was retained therein. Also note that copyright over my contributions to this crate is owned by ECC, not me.
Contributor
Author
There was a problem hiding this comment.
Yea, sorry about that. This is something I need to ask you. My plan is to add LICENSE-APACHE and LICENSE-MIT into https://github.com/oxarbitrage/openrpsee and also squash the current commits (https://github.com/oxarbitrage/openrpsee/commits/main/) into one and add you as a Co-author of that initial commit.
Let me know if that will be enough or if you prefer something else. Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a common crate for openrpc functionality: https://github.com/oxarbitrage/openrpsee as the code is shared among the Z3 stack (Zaino, Zebra, Zallet).
A similar PR exist for Zebra: ZcashFoundation/zebra#10201
This PR is a draft until a first version of
openrpseeis pushed to crates.io.