Add some recommended compiler optimizations#15
Draft
lnay wants to merge 1 commit intozed-extensions:mainfrom
Draft
Add some recommended compiler optimizations#15lnay wants to merge 1 commit intozed-extensions:mainfrom
lnay wants to merge 1 commit intozed-extensions:mainfrom
Conversation
See [discussion](zed-industries/zed#21450 (reply in thread)). You may consider adding these Cargo configurations in order to reduce the WASM bundle size as well as potential performance benefits.
Collaborator
|
Keeping this open until the discussion is resolved, will act based on that! |
Contributor
|
Hey, thanks again for this! Has been quite some time and I think generally this has settled a bit, do we want to look into this or should we close this? It's our oldest PR here in the extensions org and would be interested in both your opinions. Thanks! |
Collaborator
|
I see the discussion hasn't moved much, I would propose following the default suggested by Zed devs and this doesn't include it. From what I can see it would be a very minor improvement if any. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See
discussion.
You may consider adding these Cargo configurations in order to reduce
the WASM bundle size as well as potential performance benefits.